Handle late encryption error #1055
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not see an encryption error after unless the data is corrupted on the wire, apparently this can happen fixes #1044
CodSpeed Performance ReportMerging #1055 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2681 2681
=========================================
Hits 2681 2681 ☔ View full report in Codecov by Sentry. |
bdraco
commented
Feb 3, 2025
| # but it could happen if the server sends a bad frame see | ||
| # issue https://github.com/esphome/aioesphomeapi/issues/1044 | ||
| self._handle_error_and_close( | ||
| InvalidEncryptionKeyAPIError( |
There was a problem hiding this comment.
Maybe we need a new exception type for late encryption errors....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not see an encryption error after unless the data is corrupted on the wire or there is memory corruption on the ESP, apparently this can happen. While everything worked OK, the exception reached all the way into asyncio internals so its better to handle it internally.
fixes #1044