Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment with using uvloop in p2p/trinity #781

Closed
pipermerriam opened this issue May 25, 2018 · 2 comments
Closed

Experiment with using uvloop in p2p/trinity #781

pipermerriam opened this issue May 25, 2018 · 2 comments
Labels
comp: p2p comp: trinity type: performance

Comments

@pipermerriam
Copy link
Member

What is wrong?

Looks like uvloop could provide us some speed improvements.

We should benchmark and explore this.
@carver
Copy link
Contributor

carver commented May 28, 2018

Note that this doesn't support Windows. If benchmarks look good, then we need to fall back to the standard event loop policy on Windows.

@gsalgado
Copy link
Collaborator

Fixed in #1288

@carver carver mentioned this issue May 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: p2p comp: trinity type: performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@carver @gsalgado @cburgdorf @pipermerriam