Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Reorg BLS module #137

Closed
hwwhww opened this issue Dec 13, 2018 · 1 comment
Closed

Reorg BLS module #137

hwwhww opened this issue Dec 13, 2018 · 1 comment
Labels
effort: E2 days eth2.0 prio: P4 nice to have

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Dec 13, 2018

What is wrong?

For having better key management and convenient common interface for BLS signature.

How can it be fixed

  1. Move eth/utils/bls.py to py_ecc.
  2. Implement a new BLSKeyAPI interface in eth-keys.
    • It seems the currentKeyAPI is only for ECDSA? We may add a BaseKeyAPI, and modify the current ECDSA APIs to ECDSAKeyAPI.
    • So do PublicKey, PrivateKey and Signature interfaces.
  3. Refactor and optimize:
@hwwhww hwwhww transferred this issue from ethereum/py-evm Jan 10, 2019
@hwwhww hwwhww added the eth2.0 label Jan 10, 2019
@hwwhww hwwhww mentioned this issue Jan 28, 2019
Merged
@ralexstokes
Copy link
Member

closing this due to staleness. we can revisit if needed :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort: E2 days eth2.0 prio: P4 nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralexstokes @hwwhww