Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language selector #1687

Closed
bjohansebas opened this issue Nov 20, 2024 · 6 comments · Fixed by #1695
Closed

Add language selector #1687

bjohansebas opened this issue Nov 20, 2024 · 6 comments · Fixed by #1695
Labels
design Change, update, or fix for site UI (not content) enhancement good first issue Issues for newcomers

Comments

@bjohansebas
Copy link
Member

To improve the experience between i18n pages, adding a language selector would be very helpful. Right now, it's difficult to switch from one language to another without leaving the page you're on.
@bjohansebas bjohansebas added enhancement design Change, update, or fix for site UI (not content) good first issue Issues for newcomers labels Nov 20, 2024
@carlosstenzel
Copy link
Contributor

I like the idea

@cengizcmataraci
Copy link
Contributor

Hello there. Could I try my chance at this? It will be my first contribution.

@bjohansebas
Copy link
Member Author

@cengizcmataraci sure, PRs are welcome, feel free to ask if you have any questions.

@cengizcmataraci cengizcmataraci mentioned this issue Nov 23, 2024
Merged
@bjohansebas bjohansebas reopened this Feb 4, 2025
@bjohansebas
Copy link
Member Author

it’s strange that the selector isn’t working, when it worked on Netlify

@bjohansebas
Copy link
Member Author

I guess it has something to do with the Ruby version and how we're deploying on the site (##1747), so a quick solution would be to always display the icon instead of the language name, since it seems to work correctly on mobile. @cengizcmataraci , do you want to do that?

@bjohansebas
Copy link
Member Author

Now it is working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Change, update, or fix for site UI (not content) enhancement good first issue Issues for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add language picker cengizcmataraci/expressjs.com
3 participants
@carlosstenzel @cengizcmataraci @bjohansebas