From fbc074ce28441ea9ddd1c23493baa0dba12105d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20Unneb=C3=A4ck?= Date: Tue, 23 Jan 2024 10:22:17 +0100 Subject: [PATCH 1/2] Fix failing tests --- test/node/test-buffer-badhex.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/node/test-buffer-badhex.js b/test/node/test-buffer-badhex.js index 486e166..63e405c 100644 --- a/test/node/test-buffer-badhex.js +++ b/test/node/test-buffer-badhex.js @@ -17,9 +17,10 @@ const assert = require('assert'); // Node Buffer behavior check // > Buffer.from('abc def01','hex') // + assert.strictEqual(buf.write('00000000', 0, 'hex'), 4); assert.strictEqual(buf.write('abc def01', 0, 'hex'), 1); - assert.deepStrictEqual(buf, new Buffer([0xab])); - assert.strictEqual(buf.toString('hex'), 'ab'); + assert.deepStrictEqual(buf, new Buffer([0xab, 0, 0, 0])); + assert.strictEqual(buf.toString('hex'), 'ab000000'); const copy = Buffer.from(buf.toString('hex'), 'hex'); assert.strictEqual(buf.toString('hex'), copy.toString('hex')); @@ -53,4 +54,3 @@ const assert = require('assert'); const badHex = `${hex.slice(0, 256)}xx${hex.slice(256, 510)}`; assert.deepStrictEqual(Buffer.from(badHex, 'hex'), buf.slice(0, 128)); } - From 89b8406afa1bbc9be2f006ff3b3f672926a1a382 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20Unneb=C3=A4ck?= Date: Tue, 23 Jan 2024 11:36:19 +0100 Subject: [PATCH 2/2] Add assert covering Buffer.from with whitespaced hex --- test/node/test-buffer-badhex.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/node/test-buffer-badhex.js b/test/node/test-buffer-badhex.js index 63e405c..90c302f 100644 --- a/test/node/test-buffer-badhex.js +++ b/test/node/test-buffer-badhex.js @@ -21,6 +21,7 @@ const assert = require('assert'); assert.strictEqual(buf.write('abc def01', 0, 'hex'), 1); assert.deepStrictEqual(buf, new Buffer([0xab, 0, 0, 0])); assert.strictEqual(buf.toString('hex'), 'ab000000'); + assert.deepStrictEqual(Buffer.from('abc def01', 'hex'), Buffer.from([0xab])); const copy = Buffer.from(buf.toString('hex'), 'hex'); assert.strictEqual(buf.toString('hex'), copy.toString('hex'));