Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curio UI shows wrong "time" calculation if Browser is in a different timezone than the Curio Node server. #371

Open
8 of 12 tasks
johansealstorage opened this issue Jan 16, 2025 · 1 comment

Comments

@johansealstorage
Copy link

Checklist

  • This is not a question or a support request. If you have any Curio related questions, please ask in the discussion forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release candidate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to curio.

Curio component

  • PoRep Pipeline
  • Snap Deals
  • Market
  • IPNI provider
  • Curio UI
  • Other

Curio Version

curio version 1.24.3+calibnet+git_08785ae_2025-01-15T22:42:29+02:00

Describe the Bug

The "Create Time" on the PoRep screen is wrong.
I started a CC sector sealing and the SRD started at 8:41 am. It is now 11:35 (2 h 50 minutes later), but the PoRep screen indicates that the task started 4:51 mins ago.
My server is running in UTC time. The PC/Browser that I'm accessing Curio UI with, is in UTC+2 (SAST) time.
The PoRep screen is exactly 2 hours "out" with what it shows.

Image

And my current time on the Server:

Image

And current time on the PC that I'm accessing the Curio UI with:

Image

Logging Information

N/A

Repo Steps

  1. Run the Curio nodes on a server with UTC time set on the server.
  2. Start sealing some CC sectors.
  3. Visit the Curio UI from a machine in another timezone.
@LexLuthr
Copy link
Contributor

LexLuthr commented Jan 16, 2025

I think there is a little confusion here. "Create time" is not SDR task dependent. It is the time when this sector was created. Usually the moment sector is sent to sealing pipeline.

Now that's clarified, you time diff is still correct. Curio works with UTC. We seem to convert to localtime on the server side and send the string to client. That's why it is different.

@magik6k Any reason we did it this way? People running remote clusters may get confused about time. We seem to be doing this for a lot of UI pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants