Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to capture the state of partial messages #812

Closed
Tracked by #792
masih opened this issue Jan 7, 2025 · 0 comments · Fixed by #852
Closed
Tracked by #792

Add metrics to capture the state of partial messages #812

masih opened this issue Jan 7, 2025 · 0 comments · Fixed by #852
Assignees
@masih
Milestone
M2: Mainnet Passi...

Comments

@masih
Copy link
Member

masih commented Jan 7, 2025

A whole host of functionality is/being introduced as part of #792. Implement additional metrics to observe the new system state, namely:

  • The number of incomplete messages
  • The chain lookup table size
  • The equivocations metrics (how many, tagged by phase)
  • The chain exchange pubsub metrics: home many messages exchanged, bandwidth usage for topic would be nice.
@github-project-automation github-project-automation bot moved this to Todo in F3 Jan 7, 2025
@masih masih mentioned this issue Jan 7, 2025
Closed
@masih masih self-assigned this Jan 7, 2025
@BigLep BigLep added this to the M2: Mainnet Passive Testing milestone Jan 8, 2025
@masih masih moved this from Todo to In progress in F3 Jan 23, 2025
masih added a commit that referenced this issue Jan 27, 2025
@masih
Add chain exchange and partial message metrics
cc97a49 
Add metrics that measure various aspects of chain exchange and partial
messages, including:
 * The number of messages pending partial messages.
 * The total number instances with a partial message.
 * The chain exchange broadcast count.
 * The length of broadcast chain.
 * The time spent on chain exchange validation.
 * Qualify existing GPBFT validation metrics with partial message
   attribute.
 * The number of duplicate partial messages qualified with equivocation
 attribute.

Fixes: #812
@masih masih mentioned this issue Jan 27, 2025
Merged
@BigLep BigLep moved this from In progress to In review in F3 Jan 28, 2025
masih added a commit that referenced this issue Jan 29, 2025
@masih
Add chain exchange and partial message metrics
cfbbd79 
Add metrics that measure various aspects of chain exchange and partial
messages, including:
 * The number of messages pending partial messages.
 * The total number instances with a partial message.
 * The chain exchange broadcast count.
 * The length of broadcast chain.
 * The time spent on chain exchange validation.
 * Qualify existing GPBFT validation metrics with partial message
   attribute.
 * The number of duplicate partial messages qualified with equivocation
 attribute.

Fixes: #812
github-merge-queue bot pushed a commit that referenced this issue Jan 29, 2025
@masih
Add chain exchange and partial message metrics (#852)
81059b1 
Add metrics that measure various aspects of chain exchange and partial
messages, including:
 * The number of messages pending partial messages.
 * The total number instances with a partial message.
 * The chain exchange broadcast count.
 * The length of broadcast chain.
 * The time spent on chain exchange validation.
 * Qualify existing GPBFT validation metrics with partial message
   attribute.
 * The number of duplicate partial messages qualified with equivocation
 attribute.

Fixes: #812
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
M2: Mainnet Passive Testing
Development

Successfully merging a pull request may close this issue.

Add chain exchange and partial message metrics filecoin-project/go-f3
2 participants
@BigLep @masih