Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis auto_reconnect woes #187

Open
jabyrd3 opened this issue Apr 13, 2019 · 1 comment
Open

Redis auto_reconnect woes #187

jabyrd3 opened this issue Apr 13, 2019 · 1 comment

Comments

@jabyrd3
Copy link

jabyrd3 commented Apr 13, 2019

Hey, I noticed some confounding behavior in the redis driver.

If you've passed auto_reconnect in either 1.1 or 1.2 it mostly works! this is great! but there's an exception handler in the madeConnection method (fired when tcp handshake is complete via twisted itself) that sets RedisFactory.continueTrying to false. I'm sure there was some reasoning behind this originally, but shouldn't the driver keep trying to connect for subsequent requests even if madeConnection throws the exception the first time around?

Its line 224 in 1.1, but the same issue exists in 1.2.

If i'm missing something or being dumb, im sorry for bugging whoever's still subscribed to this repo, but this behavior is confusing to me and i'm curious about why it does what it does.

@fiorix
Copy link
Owner

fiorix commented Oct 6, 2019

The Redis driver is far behind the one in the original repo https://github.com/fiorix/txredisapi. It'd be good to sync it in cyclone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants