feat: add netcat for remote development support
#77
Conversation
|
Started test build 178178 |
|
Build 178178 successful |
| - install -Dm0755 nc /app/bin/nc | ||
| sources: | ||
| - type: archive | ||
| url: https://salsa.debian.org/debian/netcat-openbsd/-/archive/debian/1.228-1/netcat-openbsd-debian-1.228-1.tar.gz |
There was a problem hiding this comment.
Why the upstream tarball is not used here?
There was a problem hiding this comment.
The upstream tarball is for BSD only and doesn't work on Linux without patches, this Debian package bundles those patches, is tracked by Anitya, and is also used by both Arch Linux and Alpine Linux.
| url-template: https://libbsd.freedesktop.org/releases/libbsd-$version.tar.xz | ||
| cleanup: | ||
| - /lib/pkgconfig | ||
| - /share/man |
There was a problem hiding this comment.
None of these packages are part of the freedesktop SDK?
There was a problem hiding this comment.
AFAIK neither libbsd nor libmd is in the SDK, they are also compiled in other Flatpaks that need them such as com.valvesoftware.Steam.
|
Started test build 178301 |
|
Build 178301 successful |
Zed [requires](https://github.com/zed-industries/zed/blob/eb820ab800ea2a0023667b5c0eb91daa7c9ab084/crates/remote/src/ssh_session.rs#L1423-L1441) the BSD version of `netcat` for remote development. It then depends on `libbsd`, which subsequently depends on `libmd`. Starting a remote development session on another system over SSH works now with the password prompt correctly appearing. Fixes flathub#58.
|
Started test build 179089 |
|
Build 179089 successful |
|
@tomaswarynyca: have you noticed that PR? I think it deserves a review and a merge ;) |
|
I have my doubts about whether we should include this :) |
Since the flatpak is offering the option to run fully sandboxed, I think the PR makes sense for that use case.
I will recheck tomorrow and re-approve once done. But I do not think the PR author is trying to include anything weird :) |
|
Started test build 179319 |
|
Build 179319 successful |
Zed requires the BSD version of
netcatfor remote development. It then depends onlibbsd, which subsequently depends onlibmd.Starting a remote development session on another system over SSH works now with the password prompt correctly appearing.
Fixes #58.