Remove --version and --fee-token flags
#2865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cptartur
force-pushed
the
2856-remove-deprecated-txs
branch
from
1b76089 to
3a3e168
Compare
cptartur
changed the base branch from
master
to
fix-cast-script-deploy-conversion
cptartur
force-pushed
the
2856-remove-deprecated-txs
branch
from
3a3e168 to
996952d
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
… omitted (#2888) <!-- Reference any GitHub issues resolved by this PR --> Closes # ## Introduced changes <!-- A brief description of the changes --> This came up from #2865 Conversion from `ScriptFeeSettings` to `FeeSettings` resulted in value for `max_fee` being dropped completely. This conversion was only in cast script "deploy" function. If deploy was used with Strk token, any value passed to `max_fee` was completely ignored. Removed the conversion entirely and used correct structure in deploy. ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
cptartur
force-pushed
the
2856-remove-deprecated-txs
branch
from
996952d to
180dc68
Compare
cptartur
requested review from
ddoktorski,
kkawula and
franciszekjob
as code owners
ddoktorski
reviewed
Jan 30, 2025
| @@ -85,7 +85,7 @@ pub async fn create( | |||
| .context("Invalid address")? | |||
| .parse()?; | |||
|
|
|||
| let mut message = "Account successfully created. Prefund generated address with at least <max_fee> STRK tokens or an equivalent amount of ETH tokens. It is good to send more in the case of higher demand.".to_string(); | |||
| let mut message = "Account successfully created. Prefund generated address with at least <max_fee> STRK tokens. It is good to send more in the case of higher demand.".to_string(); | |||
There was a problem hiding this comment.
Suggested change
| let mut message = "Account successfully created. Prefund generated address with at least <max_fee> STRK tokens. It is good to send more in the case of higher demand.".to_string(); | |
| let mut message = format!("Account successfully created. Prefund generated address with at least {max_fee} STRK tokens. It is good to send more in case of higher demand."); |
And actually we should either replace STRK with FRI in the message or divide this value by 10^18. It could also be renamed to estimated_fee or something like that.
| @@ -390,6 +390,7 @@ async fn test_run_script_twice_with_state_file_enabled() { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| // #[ignore] | |||
There was a problem hiding this comment.
Suggested change
| // #[ignore] |
| @@ -537,6 +537,7 @@ pub fn assert_tx_entry_failed( | |||
| status: ScriptTransactionStatus, | |||
| msg_contains: Vec<&str>, | |||
| ) { | |||
| dbg!(&tx_entry); | |||
There was a problem hiding this comment.
Suggested change
| dbg!(&tx_entry); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2856
Introduced changes
--versionand--fee-tokenflags in sncastChecklist
CHANGELOG.md