Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for data transformer types #2575

Closed
integraledelebesgue opened this issue Oct 11, 2024 · 8 comments · Fixed by #2876
Closed

Add unit tests for data transformer types #2575

integraledelebesgue opened this issue Oct 11, 2024 · 8 comments · Fixed by #2876

Comments

@integraledelebesgue
Copy link
Member

integraledelebesgue commented Oct 11, 2024

Component the issue is related to

Data Transformer

Issue

At the moment, representations of Cairo numeric types provided by data-transformer are not fully tested.
A proper unit tests need to be added in bytes31, u96 and u384. Also, utility functions from the helpers modules should be tested.

Below is an example test which you can refer to:
https://github.com/foundry-rs/starknet-foundry/blob/master/crates/conversions/tests/e2e/non_zero_u128.rs

@danielrobotz
Copy link

Can I try solving this issue?

@Nityam573
Copy link
Contributor

Let me try this one!

@emarc99
Copy link

emarc99 commented Jan 22, 2025

Let me do this, I have written in Rust and Cairo.

@mexes20
Copy link

mexes20 commented Jan 22, 2025

May I handle this issue?

@ussyalfaks
Copy link

Can I attempt this issue?

@aguilar1x
Copy link

May I take this issue on?

Hi, my name is Matías Aguilar. I am a software development engineer with 1 year of experience in backend and some frontend. I am a maintainer of projects like RevolutionaryFarmers and StarShop, focusing on Smart Contracts using Rust, and I also have experience with Cairo, I was creating contracts for a project integrated into the Winter Hackathon and participating in the StarkNet Hacker House. I am passionate about design, which is why I enjoy UI/UX, and I have a natural ability to create effects or design anything that might be needed. Along with my team, I won first place in one of the tracks at the Eth Pura Vida hackathon. My experience in both frontend and backend enables me to carry out a wide variety of tasks to achieve set goals.

I am also skilled in documentation, ensuring that the reading experience is clean, concise, and enjoyable for the reader. I apply various visual techniques to make the content engaging and appealing. I am a member of Dojo Coding, and I would really love to participate in the project with this issue.

@1nonlypiece
Copy link

Application for Contribution

I am excited about the opportunity to contribute to this issue and am confident that my expertise aligns well with the requirements. With a strong background in Cairo programming and decentralized application development on StarkNet, I bring a well-rounded skill set to deliver an effective solution.

Relevant Expertise

  • Blockchain & Smart Contracts: Extensive experience with StarkNet, Stellar, and Rust, specializing in developing secure and optimized smart contracts, blockchain integrations, and high-performance backend infrastructure.
  • Backend Development: Well-versed in API design, server-side logic, and scalable system architecture, ensuring efficient and seamless backend performance.
  • Frontend Engineering: Skilled in crafting interactive and responsive UI components using React and Next.js, enhancing the user experience for blockchain-based platforms.

Why Consider My Application?

My proven track record of delivering high-quality, optimized solutions in blockchain and full-stack development sets me apart. I have a deep understanding of smart contract security, decentralized architectures, and the synergy between frontend, backend, and blockchain layers—ensuring a seamless and efficient implementation.

ETA

I expect to have a working solution ready within 48 hours. Please let me know if I can proceed with the implementation.

@od-hunter
Copy link
Contributor

Hi, please can I be assigned this please? I am a returning contributor and I would love to be given the opportunity to solve this issue please. I am very good with tests and I have experience in html, css, JavaScript, TypeScript, cairo and rust.

github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2025
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2575 

## Introduced changes

<!-- A brief description of the changes -->

Added u384 tests, u96 tests and bytes31 tests

## Checklist

<!-- Make sure all of these are complete -->

- ✅ Linked relevant issue
- ✅ Updated relevant documentation
- ✅ Added relevant tests
- ✅ Performed self-review of the code
- ✅ Added changes to `CHANGELOG.md`

---------

Co-authored-by: Franciszek Job <[email protected]>
Co-authored-by: Artur Michałek <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Starknet foundry Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants