Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DictStateReader #2891

Open
franciszekjob opened this issue Jan 29, 2025 · 5 comments · May be fixed by #2897
Open

Refactor DictStateReader #2891

franciszekjob opened this issue Jan 29, 2025 · 5 comments · May be fixed by #2897
Labels
good first issue Good for newcomers new refactor snforge

Comments

@franciszekjob
Copy link
Collaborator

Current State

ATM, DictStateReader has a couple fields which are never modified.

In scope of this task we should:

  • remove storage_view, address_to_nonce, class_hash_to_compiled_class_hash fields
  • adjust methods in DictStateReader which read these fields, so they always return error

Objective

get_storage_at, get_nonce_at, get_compiled_class_hash in DictStateReader should always return error

Additional Context

No response
@franciszekjob franciszekjob added the good first issue Good for newcomers label Jan 29, 2025
@github-actions github-actions bot added the new label Jan 29, 2025
@od-hunter
Copy link
Contributor

od-hunter commented Jan 29, 2025 •
edited
Loading

Hi, please can I be assigned this please? I would love to be the given the opportunity to solve this issue please. I have experience in html, css, JavaScript,TypeScript, Cairo and Rust. I am up for the task and I'll open a pr in 24 hours.

@SudiptaPaul-31
Copy link

Can I contribute to this issue?

@beeguy74
Copy link

beeguy74 commented Jan 29, 2025 •
edited
Loading

Hi, worked with this part in test issue already. So i think i can start quite fast.
i'll do a draft PR in the morning, so you can see the progress

@pheobeayo
Copy link

Can I jump on this task?

@GideonBature
Copy link

May I take care of this?

@franciszekjob franciszekjob linked a pull request Jan 29, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers new refactor snforge
Projects
Starknet foundry
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor DictStateReader foundry-rs/starknet-foundry
6 participants
@pheobeayo @franciszekjob @beeguy74 @GideonBature @SudiptaPaul-31 @od-hunter