fix: respect "editor.formatOnSave": false #303
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `editor.formatOnSave` from true to false, but still formatted.
|
In my environment, since commit 2885fbc and its merge commit (f0b43e0) , shell-format has stopped working. I get the following error message.
I made the following changes to 32e6f3c and did diff --git a/package.json b/package.json
index 9ebc66c..7f70f38 100644
--- a/package.json
+++ b/package.json
@@ -209,7 +209,7 @@
},
"dependencies": {
"diff": "~5.1.0",
- "editorconfig": "^2.0.0"
+ "editorconfig": "^0.15.3"
},
"licenses": [
{Sorry if this is a problem specific to my environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
"editor.formatOnSave": falsesetting is now respected."editor.formatOnSave" is now immediately toggled with or without formatting when changed from True to False or False to True.
resolve #303
Problems that were occurring
When VSCode was started with
editor.formatOnSave":trueand changed toeditor.formatOnSave":false, the formatting continued on saving after the change.When VSCode was restarted, formatting on save was no longer performed.
Ohter