Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow danger variant to be disabled #473

Open
ojeytonwilliams opened this issue Jan 30, 2025 · 0 comments
Open

Allow danger variant to be disabled #473

ojeytonwilliams opened this issue Jan 30, 2025 · 0 comments

Comments

@ojeytonwilliams
Copy link
Contributor

freeCodeCamp/freeCodeCamp#55724 makes the danger button disabled until the user has entered the expected text.

@huyenltnguyen I know this was intentional, but now we have some tension: we can only get the client to pass type-checking if we use ts-ignore/ts-expect-error, which isn't ideal. Given the use-case in the linked PR, can we allow the danger variant to be disabled or does the client need to do something differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant