Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew fails when tapping homebrew/core #85

Closed
andreasbrgmn opened this issue Dec 20, 2023 · 6 comments · Fixed by #87
Closed

Homebrew fails when tapping homebrew/core #85

andreasbrgmn opened this issue Dec 20, 2023 · 6 comments · Fixed by #87

Comments

@andreasbrgmn
Copy link

It seems Homebrew has recently switched behavior when user taps the default cask homebrew/core (PR|commit). Instead of warning user, it now fails the process, which ultimately causes the step Ensure configured taps are tapped (link) to fail since homebrew/core is the default value of homebrew_taps.

Ex. output:

TASK [geerlingguy.mac.homebrew : Ensure configured taps are tapped.] **************************************************************************************************************************************
failed: [Node-1] (item=homebrew/core) => changed=false 
  ansible_loop_var: item
  item: homebrew/core
  msg: |-
    added: 0, unchanged: 0, error: failed to tap: homebrew/core due to Error: Tapping homebrew/core is no longer typically necessary.
    Add --force if you are sure you need it done.
@kalabiyau
Copy link

kalabiyau commented Dec 20, 2023

as a temp workaround we override homebrew_taps like here:

homebrew_taps: []

when required we feed explicit taps as vars to a task

@Guray00
Copy link

Guray00 commented Dec 20, 2023

Sorry for the dumb question, where should we put that line?

@kalabiyau
Copy link

No such thing as a dumb question @Guray00 ;) we put into our top-level inventory group_var aka all.yml. Some examples you can find here

@andreasbrgmn
Copy link
Author

as a temp workaround we override homebrew_taps like here:

homebrew_taps: []

when required we feed explicit taps to as vars to a task

Ah sweet, thanks @kalabiyau

@nqui
Copy link

nqui commented Jan 4, 2024

as a temp workaround we override homebrew_taps like here:

homebrew_taps: []

when required we feed explicit taps as vars to a task

Hi @kalabiyau, are you running this on an apple silicon mac? On an intel mac, this override doesn't work. I've added a debug task to print the value of homebrew_taps. Even with homebrew_taps: [] set in defaults/main.yml:

TASK [geerlingguy.mac.homebrew : print homebrew_taps] *********************************
ok: [127.0.0.1] => 
  msg:
  - homebrew/core
  - homebrew/cask

TASK [geerlingguy.mac.homebrew : Ensure configured taps are tapped.] ******************
failed: [127.0.0.1] (item=homebrew/core) => changed=false 
  ansible_loop_var: item
  item: homebrew/core
  msg: |-
    added: 0, unchanged: 0, error: failed to tap: homebrew/core due to Error: Tapping homebrew/core is no longer typically necessary.
    Add --force if you are sure you need it done.
failed: [127.0.0.1] (item=homebrew/cask) => changed=false 
  ansible_loop_var: item
  item: homebrew/cask
  msg: |-
    added: 0, unchanged: 0, error: failed to tap: homebrew/cask due to Error: Tapping homebrew/cask is no longer typically necessary.
    Add --force if you are sure you need it done.

@kalabiyau
Copy link

@nqui we use both and it worked for us on both afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants