Don't follow symlinks when setting Homebrew permissions #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Homebrew directory (/usr/local/Homebrew or /opt/homebrew) contains symlinks to files outside of that directory tree. For example, casks link to their respective app in /Applications. Some of these apps in /Applications contain cyclic directory structures, which causes a filename-too-long error when Ansible tries to recurse into those directories. This commit fixes that problem by setting follow: false, so Ansible will not follow any links under the Homebrew install path when setting the permissions of the subdirectories.
|
Linting fails but not because of changes introduced by this PR. I'd also be happy to fix the linting errors so CI passes, but it would involve changes unrelated to the purpose of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107. Fixes #93.
In short, this changes the task which sets the permissions on
/opt/homebrewor/usr/local/Homebrewsubdirectories so that it no longer follows symlinks.For a more detailed explanation, see my comment in #107 here.
I have tested this on my machine (M2) but I do not have access to an x86 machine to test on.