Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons broken after updating from 2.13.0 -> 2.16.0 #1511

Open
viktorsmari opened this issue Aug 22, 2024 · 3 comments
Open

Some icons broken after updating from 2.13.0 -> 2.16.0 #1511

viktorsmari opened this issue Aug 22, 2024 · 3 comments

Comments

@viktorsmari
Copy link

viktorsmari commented Aug 22, 2024

image

Here we have some icons (not all) broken after this update.

When inspecting we see some don't work
image

Some work
image

When I open up a broken icon in a new tab it actually works:
image

Could the %0A be a part of the issue?
image

Any ideas how I could debug further?

@viktorsmari
Copy link
Author

viktorsmari commented Aug 23, 2024

If I use a CDN it works, so I cannot reproduce on JSFiddle.

I am using Ruby on Rails and esbuild.

package.json:

  "dependencies": {
    "@geoman-io/leaflet-geoman-free": "^2.16.0",

app/assets/stylesheets/application.bootstrap.scss:

@import 'leaflet.markercluster/dist/MarkerCluster.Default';
@import 'flatpickr/dist/flatpickr';
@import '@geoman-io/leaflet-geoman-free/dist/leaflet-geoman';

This works fine in earlier versions:

  • 2.13 works
  • 2.15 works
  • 2.16 does not work
  • 2.17 does not work

@viktorsmari viktorsmari changed the title Some icons broken after updating from 2.13.0 -> 2.17.0 Some icons broken after updating from 2.13.0 -> 2.16.0 Aug 23, 2024
@Falke-Design
Copy link
Collaborator

Hi,
with the 2.16.0 Version we accidentally made a breaking change. The build process was updated and sometimes causes problems with older builders.
We suggest to try to update your builder.

See: https://github.com/geoman-io/leaflet-geoman/releases/tag/v2.16.0

@viktorsmari
Copy link
Author

Thanks @Falke-Design
I am using version 0.23.1 of esbuild - but still having this issue. What else should I upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants