-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry.close
must be called in an isolate otherwise it won't shut down
#2625
Comments
I tested with the following code. import 'dart:isolate';
import 'package:sentry/sentry.dart';
Future<void> main(List<String> arguments) async {
print('before sentry isolate');
await Isolate.run(_sentryIsolate);
print('after sentry isolate');
}
Future<void> _sentryIsolate() async {
print('sentry isolate start');
await Sentry.init((options) {
options.dsn = 'https://[email protected]/5428562';
});
// await Sentry.close();
print('sentry isolate end');
} It makes no difference if we close sentry or not, the output is the same in both cases. denis@MacBook-Pro metrics % ./perf_test_console_sentry.bin
before sentry isolate
sentry isolate start
sentry isolate end
after sentry isolate @buenaflor Can we reach the user somehow to get a sample where this is occurring? |
cc @bsutton |
here is a link to the source file that had the problem. https://github.com/bsutton/hmb/blob/wip/lib/database/management/backup_providers/zip_isolate.dart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
"I'm calling
Sentry.init
in my isolate (the non-flutter variant) and found my isolate wouldn't shutdown until I addedSentry.close
as the last line in the isolate."Let's verify this first and then document it
The text was updated successfully, but these errors were encountered: