Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingit includes undocumented API call to ntdll.dll!NtAssignProcessToJobObject (and a few others) due to dependency in msys2.0.dll #5358

Open
veronicagg opened this issue Jan 11, 2025 · 1 comment
Labels

Comments

@veronicagg
Copy link

Our team has identified msys2.0.dll calling undocumented Windows APIs like ntdll.dll!NtAssignProcessToJobObject - which is included in mingit/Git for Windows.
Code pointer in cygwin: https://github.com/search?q=repo%3Acygwin%2Fcygwin+NtAssignProcessToJobObject&type=code with a caller: cygwin/winsup/cygwin/resource.cc at 21a2c9db6952954608cdf92638b411b15e7606c6 · cygwin/cygwin

We believe the undocumented call should get replaced by the following documented API - AssignProcessToJobObject function (jobapi2.h) - Win32 apps | Microsoft Learn

Here are some other undocumented API calls also identified:

  • NtOpenJobObject
  • NtCreateJobObject
  • NtOpenMutant
  • NtQueryInformationJobObject
  • NtSetInformationJobObject

Could a change be driven to update the above? We will investigate further to try to propose a change. Thanks!

@rimrul rimrul added the cygwin label Jan 11, 2025
@dscho
Copy link
Member

dscho commented Jan 13, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants