Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD_CSS hook does not work as expected for SCSS files #18788

Open
2 tasks done
cedric-anne opened this issue Jan 22, 2025 · 0 comments
Open
2 tasks done

ADD_CSS hook does not work as expected for SCSS files #18788

cedric-anne opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels

Comments

@cedric-anne
Copy link
Member

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

11.0.0-dev

Bug description

The SCSS files registered in the ADD_CSS hook are not working as expected.

  1. Only SCSS files located in the public directory should be exposed, therefore /css/styles.scss should serve the compiled CSS from the /public/css/styles.scss file.
  2. If the plugin is located in another directory than /plugins, the compilation fails as GLPI tries to access the SCSS file in the /plugins dir.

Relevant log output

Page URL

No response

Steps To reproduce

  1. Get a plugin that registers a SCSS file in the ADD_CSS hook and place it in the /marketplace dir.
  2. See that the /front/css.php?file=plugins/myplugin/css/styles.scss URL fails with an error.

Your GLPI setup information

No response

Anything else?

No response

@cedric-anne cedric-anne self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant