From 2717d7e9a6a58bd357bceeca317fd0b4835312ae Mon Sep 17 00:00:00 2001 From: Andrew Ayer Date: Fri, 4 Oct 2024 07:35:32 -0400 Subject: [PATCH] Remove obsolete comments about Ed25519 support --- v2/piv/key.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/v2/piv/key.go b/v2/piv/key.go index 4666077..8cb619f 100644 --- a/v2/piv/key.go +++ b/v2/piv/key.go @@ -440,8 +440,6 @@ type Algorithm int // Algorithms supported by this package. Note that not all cards will support // every algorithm. // -// AlgorithmEd25519 is currently only implemented by SoloKeys. -// // For algorithm discovery, see: https://github.com/ericchiang/piv-go/issues/1 const ( AlgorithmEC256 Algorithm = iota + 1 @@ -1402,8 +1400,6 @@ func ykECDHX25519(tx *scTx, slot Slot, pub *ecdh.PublicKey, peer *ecdh.PublicKey return sharedSecret, nil } -// This function only works on SoloKeys prototypes and other PIV devices that choose -// to implement Ed25519 signatures under alg 0x22. func skSignEd25519(tx *scTx, slot Slot, pub ed25519.PublicKey, digest []byte) ([]byte, error) { // Adaptation of // https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-73-4.pdf#page=118