Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the get enrollments for student API call I think there is an error where the pages available is greater than the actual pages for the paginated call. Happens when the page size is equal to the enrolments. #305

Open
4 tasks
robbiefarai opened this issue Dec 3, 2022 · 2 comments
Assignees
Labels
Status: Can't Recreate Unable to recreate using the provided information or recreation steps Status: Need Information More information is required to proceed

Comments

@robbiefarai
Copy link

Reproduction Steps

  • Include clear and detailed step by step instructions on how the issue can be reliably reproduced
  • Include screenshots where applicable
  • Record a video if possible (if you post a video please still include a text version of your recreation steps!)

Expected Behavior

  • Include a concise description of what you expected to happen (but didn't)

Actual Behavior

  • Include a concise description of what actually happens (but isn't supposed to)

Error Messages / Logs

  • Include any relevant error messages or log files
<!-- Paste error logs / backtraces below this line -->

System and Environment Information

System Report


This issue has be recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme

Browser, Device, and Operating System Information

  • Browser name and version
  • Operating System name and version
  • Device name and version (if applicable)
@thomasplevy thomasplevy self-assigned this Dec 3, 2022
@eri-trabiccolo
Copy link
Contributor

Hi @robbiefarai
thanks for reporting this.
I'm not sure I got the issue. I tried retrieving the enrollments of a user who has 6 enrollments, via:
wp-json/llms/v1/students/1/enrollments?per_page=6
I got the correct response, with:

X-WP-Total: 6
X-WP-TotalPages: 1

Can you please give us some more information on how to reproduce the issue, and what's the issue about? I mean, what do you expect to happen and what happens instead?

Many thanks!

@eri-trabiccolo eri-trabiccolo added Status: Can't Recreate Unable to recreate using the provided information or recreation steps Status: Need Information More information is required to proceed labels Dec 5, 2022
@eri-trabiccolo eri-trabiccolo transferred this issue from gocodebox/lifterlms Dec 5, 2022
@eri-trabiccolo eri-trabiccolo moved this from Awaiting Triage to Backlog in Development Dec 27, 2022
@robbiefarai
Copy link
Author

Sorry for the late response. Our API programmer reported it. We just implemented checks on our end to make sure it doesn't crash our code on our side. All I remembered was that we had 100 posts and page size 100. I will ask him he he can reproduce again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Can't Recreate Unable to recreate using the provided information or recreation steps Status: Need Information More information is required to proceed
Projects
Status: Backlog
Development

No branches or pull requests

3 participants