Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL: Clarify bzero related usage #13

Open
jpaskhay opened this issue Jun 24, 2019 · 1 comment
Open

ALL: Clarify bzero related usage #13

jpaskhay opened this issue Jun 24, 2019 · 1 comment

Comments

@jpaskhay
Copy link
Contributor

There are some notes and TODOs around bzero usage in the Java and C# repos. Need to investigate and clarify any open questions. Apply any needed changes and/or cleanup comments.

@jgowdy
Copy link
Contributor

jgowdy commented Oct 7, 2020

This is a non-issue. The purpose of explicit_bzero is to avoid C compilers from determining the call to bzero is useless and optimizing it away. We are accessing glibc at runtime via a dynamic call directly to the bzero function. There is no opportunity for this call to be optimized away as a dynamic call at runtime. I've removed the comments from C# and Java in #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants