Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] cleanup securememory #209

Open
nikoo28 opened this issue Jun 4, 2020 · 1 comment
Open

[C#] cleanup securememory #209

nikoo28 opened this issue Jun 4, 2020 · 1 comment

Comments

@nikoo28
Copy link
Contributor

nikoo28 commented Jun 4, 2020 •
edited
Loading

there are a couple of pending cleanup tasks in the Windows implementation for C#

  • found some unused imports
  • the visibility of some methods can be made private
  • remove BOM/CLRF in /csharp/SecureMemory/PlatformNative/LLP64/Windows/WindowsInterop.cs
  • remove BOm/CLRF in /csharp/SecureMemory/SecureMemory/ProtectedMemoryImpl/Windows/WindowsProtectedMemoryAllocatorLLP64.cs
@nikoo28 nikoo28 mentioned this issue Jun 4, 2020
Merged
@nikoo28 nikoo28 changed the title cleanup C# securememory [C#] cleanup securememory Jun 10, 2020
jgowdy added a commit to jgowdy/asherah that referenced this issue Oct 7, 2020
@jgowdy
Clean up Windows support as mentioned in Issue godaddy#209
5e6c0fc
@jgowdy
Copy link
Contributor

jgowdy commented Oct 7, 2020 •
edited
Loading

This is resolved in #300

jgowdy added a commit to jgowdy/asherah that referenced this issue Oct 9, 2020
@jgowdy
Clean up Windows support as mentioned in Issue godaddy#209
16a818f
jgowdy added a commit to jgowdy/asherah that referenced this issue Oct 9, 2020
@jgowdy
Clean up Windows support as mentioned in Issue godaddy#209
0103e95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgowdy @nikoo28