You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The easy fix would be to keep the early return in DeterminePropertyInfo but removing the ReportDiagnostic calls and changing the comments to indicate that case is handled by a different generator class. Ideally IMO there wouldn't be multiple classes deriving the same information and doing the same validation to begin with but that is a different issue.
Steps to reproduce
Try to export a read only or write only property.
Minimal reproduction project (MRP)
n/a
The text was updated successfully, but these errors were encountered:
Tested versions
Introduced by #67304 starting in 4.2
System information
n/a
Issue description
Given the code
the diagnostic errors for read only and write only property exports are raised twice:
due to ScriptPropertiesGenerator.cs previously having relied on
WhereIsGodotCompatibleType
to filter those cases out. The errors are otherwise raised ScriptPropertyDefValGenerator.cs alongside other export property checks.The easy fix would be to keep the early return in
DeterminePropertyInfo
but removing theReportDiagnostic
calls and changing the comments to indicate that case is handled by a different generator class. Ideally IMO there wouldn't be multiple classes deriving the same information and doing the same validation to begin with but that is a different issue.Steps to reproduce
Try to export a read only or write only property.
Minimal reproduction project (MRP)
n/a
The text was updated successfully, but these errors were encountered: