-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what about private repos? #2
Comments
The easiest thing to fix this is by installing app engine If you don't want to use appengine you have to pull out the urlfetches The code is really hacky so I think your best bet is to install appengine ;) I am not allowed to touch the code untill the judging phase of the Good luck 2015-01-29 23:42 GMT+01:00 Einthusan Vigneswaran [email protected]:
|
In that case i will wait for you to clean it up, and i think many others will benefit from removing the link to app engine.. however, if i do get desperate enough, I may mess around with a fork. thanks for the awesome work! |
Thank you, it feels good to know that some people like it ! I didn't spent much time writing this so it probably makes no sense but it might help you. If you want to change it for private repos, here are some tips: The github crawler searches your github repo directory for go files and deeper directories. For a private repo I would leave out the whole github html scanning and just use os to find the files in your local file system. Tear out all the db stuff and create a crawler to scan your file system once. Make the crawler global or something. Then, when you make a /view/.../.../.. request, find the package in cr.Analysis.Repo.Pkgs[..]. The type conversion from Package to DBPackage is very badly designed due to the time constraints of the hackathon. So something like this:
Summary:
|
thanks for the details. I have been building an internal closed source web framework in Go for about 1.5 year now, so I am pretty sure I'd be able to figure this out, if and when I get time. Why were you using a database in the first place? Just out of curiosity.. if you were under time constraints, and assuming you were storing either fetched repos or using it like some sort of cache, isn't that time consuming to implement? |
2015-01-31 3:03 GMT+01:00 Einthusan Vigneswaran [email protected]:
|
:) regardless, you pulled off a very useful tool in the short time period. best of luck! :D |
Thank you |
I tried running my own local copy of this site, but got compile errors.
are appengine packages a must?
can we replace them with defined interface calls?
Would it work if I forked my own copy and made the changes myself? I didn't look into the code yet.
The text was updated successfully, but these errors were encountered: