-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: BottomSheetModal won't show up in EXPO SDK 52 #2035
Comments
Same bug |
Have the same issue, please fix soon ! |
Mesmo problema aqui |
same |
Same |
I am also having the same issue on SDK 52 with version 5.0.5. I find it only seems to not appear when I use a Finally, the animation on appear for the flashlist when I was able to get it to appear seems to be a lot less performant than it was in expo SDK 51. The slide up is jerky when it was previously smooth. |
Having the same issue with the update of Expo SDK 52, BottomSheet shows on Android devices but not IOS. |
Same issue here in SDK 52 and version 5.0.5, looks like adding
But I tried with |
I recommend following this great tutorial to build a BottomSheet from Scratch. |
Same issue! |
it should be fixed with the latest release, thanks for reporting it |
Thank you so much for your attention on this issue @gorhom ✨🥳 |
After upgrading to your latest release, I noticed that nothing has changed. Moreover, since Expo 52, your BottomSheet is not working as well as before. Take a look at this simple component that was working perfectly before Expo 52, but now it doesn’t open : import React, { useCallback } from "react"; const BottomSheetConfirmation = ({ const renderBackdrop = useCallback( return (
); export default BottomSheetConfirmation; |
Ok for those who have an issue i have a fix for you. Just add a BottomSheetView component from the same library inside the BottomSheetModal If you ask me why we need to add this with Expo 52 and not in expo 51 so go figure...cause i don't know |
I am still struggling with this after upgrading to 5.0.6 for bottom sheet. when i press a button to open my bottom sheet, the sheet doesn't pull up at all and there's only a white sliver at the bottom of my screen that i have to carefully press and pull up to get it to open all the way to the top snap point. but the opacity layer that darkens the screen behind the sheet does show up like normal.
|
lol it just randomly started working. i made an update to an animated view on the same page where the bottom sheet is rendered. react native 0.76 changed the way they deal with animated views so i suppose fixing that somehow played a role i in fixing the issue with my bottom sheet? not sure but that's the only thing i changed that made the bottom sheet start working properly without changing any of the code in the bottom sheet Update: yes it was completely random because now it randomly stopped working again. man, this upgrade to Expo SDK 52 is gonna be fun... |
enableDynamicSizing={false} May have fixed it for me |
This worked for me as well. Made no other change. Thanks man. |
@shihabist Thanks, This worked for me as well |
It worked for me as well!
Any reason why this is the case? |
I have been looking for this solution for past 4 days . I was about to lose my mind.. thank you for solution |
Thanks for the fix |
Worked for me as well! |
This fixed it for some users, but not all (which is super strange), does anyone have an alternative solution? |
enableDynamicSizing={false} works for me too!! Thanks a lot! |
I felt that since there's still reports here that this issue is still occurring (and I'm able to reproduce in Expo Snack) I thought that we'd best re-open it 🙏 #2126 |
Version
v5
Reanimated Version
v3
Gesture Handler Version
v2
Platforms
iOS, Android
What happened?
I have a pressable button to open the bottomsheetmodal, and when I use the SDK 51, it works perfectly. So, the onPress function fires the
![Screen Shot 2024-11-14 at 16 51 38](https://private-user-images.githubusercontent.com/30646160/386140966-0770f210-b34b-4dd6-b11c-fd7348d45a75.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDg5ODksIm5iZiI6MTczOTM0ODY4OSwicGF0aCI6Ii8zMDY0NjE2MC8zODYxNDA5NjYtMDc3MGYyMTAtYjM0Yi00ZGQ2LWIxMWMtZmQ3MzQ4ZDQ1YTc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA4MjQ0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjYzZhOTMzNjZlMjAwNWVkZjliZmVkYjgwNTY4YWUwNmZmYTkwZmEwYzUzYmZhZDZlYWM0OWQ1YTEzM2Y3Y2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zXGyNJYNx_2CJjNx6YzbEBBWL247kOYLN-rdqeO6GXs)
bottomsheetRef.current.present()
method, and the bottom sheet modal gonna show up to the snapPoints.But yesterday I started to upgrade to expo SDK 52 and then update all the libraries to its latest version base on what expo-doctor ordered me to install.
And when I already finished upgrading the expo sdk, react native, and all libraries version, then I start and test the bottomsheetmodal if its still workin. But it doesn't show up anything, and when I checked using console.log, it gave me undefined for the
bottomsheetRef.current.present()
method. And the reanimated always gave me warnings about thevalue
from bottom sheet everytime it got re-rendered on the screen.I can't even open the bottommodalsheet on sdk 52 in this snack below that I got from ur sample code template:
https://snack.expo.dev/@gorhom/bottom-sheet---issue-reproduction-template
You can check the codes in Reproduction sample below.
Reproduction steps
Reproduction sample
https://snack.expo.dev/@princesp/test-maps
Relevant log output
No response
The text was updated successfully, but these errors were encountered: