Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links in browser #8

Closed
guyfedwards opened this issue Dec 28, 2022 · 4 comments
Closed

Open links in browser #8

guyfedwards opened this issue Dec 28, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@guyfedwards
Copy link
Owner

Add ability to open (maybe also mouse support?) for links within an article

@guyfedwards guyfedwards added enhancement New feature or request help wanted Extra attention is needed labels Dec 28, 2022
@p5quared
Copy link

p5quared commented Sep 18, 2023

In newsboat all links are followed by a [x] thing, where x is a number and at the very bottom of the article there's a section like the following:

[1] first link in the article url [2] second link in the article url

In newsboat you can configure a key where after pressing it inside an article it will prompt you for a number and after specifying which number/link you meant it opens it in a web browser.

What do you think of the Newsboat approach mentioned in #34?
A simple <#> to open any links; and just add an annotation for each link that is rendered.

Some sort of popup modal seems like overkill?

@guyfedwards
Copy link
Owner Author

Yea I think that seems like a good solution. It generally seems that newsboat has a lot of good UX features so can worth building on them. Unsure about the best ui for it, probably a panel up from the bottom with list of links and the numbers that can then be selected by typing the desired link number., similar to how the ? help panel appears currently

@p5quared
Copy link

p5quared commented Sep 19, 2023

What about supporting two options?
For example:

  • o + <#> opens a link with annotation [#](haven't looked enough into bubbletea but I'd imagine there's a way to register multi-key inputs)

  • O opens list of all links, and then press some <#> to open a specific link?

If this seems agreeable I can look into implementing.

@guyfedwards
Copy link
Owner Author

Yea those seem like solid sugggestions, would welcome the contribution.

One thing to note on the opening aspect is not to rely on xdg-open being on the system and so perhaps defaulting to xdg-open but allowigin a config option for overriding with another binary would be good.

guyfedwards added a commit that referenced this issue Nov 8, 2023
- sqlite refactor and removal of cache (#5)
- split out rss parsing and test
- add migrations
- add Read for items and h/l navigation through items;
- show/hide read and mark as read (#35)
- open in browser (#8)
- add filtering (#34, #4)
- autoread config option
guyfedwards added a commit that referenced this issue Nov 8, 2023
- sqlite refactor and removal of cache (#5)
- split out rss parsing and test
- add migrations
- add Read for items and h/l navigation through items;
- show/hide read and mark as read (#35)
- open in browser (#8)
- add filtering (#34, #4)
- autoread config option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants