Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5]Add no-selenium options #55

Open
hahwul opened this issue Feb 22, 2020 · 6 comments
Open

[v1.5]Add no-selenium options #55

hahwul opened this issue Feb 22, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@hahwul
Copy link
Owner

hahwul commented Feb 22, 2020

selenium is very slow and busy to system.
I think user's need an option.

@hahwul hahwul added the plan label Feb 22, 2020
@hahwul hahwul added this to the v1.5 milestone Feb 22, 2020
@bsysop
Copy link

bsysop commented Feb 22, 2020

I would think is two steps maybe:

  • xsstrike use regex
  • knoxx use browser validation

I have made some software to find xss which detect alert() with selenium, so trivial.

Two steps would be:

  • Regex first (just a simple request)
  • Selenium after just for validation if confirmed or not

What do you think?

@hahwul hahwul self-assigned this Feb 22, 2020
@hahwul hahwul changed the title Add no-selenium options [v1.5]Add no-selenium options Feb 22, 2020
@hahwul
Copy link
Owner Author

hahwul commented Feb 22, 2020

Hi @bsysop !
Thank you so much for your opinion!
Right. That's why I'm thinking about this issue.
But I still haven't figured out what's better.

I don't know if it's really meaningful to check again with selenium for the result that the attack code has been accurately reflected. Rather, I think it's better to cut back on resources and use them only in point(polyglot, in js, DOM) where selenium is really needed.

@hahwul
Copy link
Owner Author

hahwul commented Feb 22, 2020

@bsysop
but, I still need more think.
Ah, and thank you so much for the give the PoC yesterday :)

@bsysop
Copy link

bsysop commented Feb 22, 2020

You right!

Dont worry, here for anything you need. =]

I will send you dm now with something could help this

@hahwul
Copy link
Owner Author

hahwul commented Feb 25, 2020

@bsysop
What you gave me was very helpful! Thanks, man :)

@bsysop
Copy link

bsysop commented Feb 25, 2020

=] You welcome \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants