Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up Perl::Critic gripes #170

Open
moseshll opened this issue Apr 15, 2024 · 0 comments
Open

Clear up Perl::Critic gripes #170

moseshll opened this issue Apr 15, 2024 · 0 comments
Assignees

Comments

@moseshll
Copy link
Collaborator

moseshll commented Apr 15, 2024

There are six gripes bin/criticize.pl reports over the codebase. None of these seem like breaking issues but they should be cleaned up. In particular, there is one use of :utf8 instead of :encoding(UTF-8) that could have implications.

I also have a version of criticize.pl that tests lib/ and bib_rights/ as well as the traditional source locations, this should be used in place of the existing binary.

@moseshll moseshll self-assigned this Nov 5, 2024
moseshll added a commit that referenced this issue Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant