Compilation Errors After Downloading from Latest Version

[zoushiyin]

Hello,

I hope this message finds you well. I recently downloaded the latest version of the project, but I encountered some compilation errors when trying to build it. I would greatly appreciate any assistance you can provide to help resolve these issues.

Compilation Errors:
/deskhop/src/tasks.c: In function 'screensaver_jitter':
/deskhop/src/tasks.c:82:14: error: initializer element is not constant
.y = jitter_distance,
^~~~~~~~~~~~~~~
/deskhop/src/tasks.c:82:14: note: (near initialization for 'report.y')
CMakeFiles/deskhop.dir/build.make:242: recipe for target 'CMakeFiles/deskhop.dir/src/tasks.c.obj' failed
make[2]: *** [CMakeFiles/deskhop.dir/src/tasks.c.obj] Error 1
CMakeFiles/Makefile2:1495: recipe for target 'CMakeFiles/deskhop.dir/all' failed
make[1]: *** [CMakeFiles/deskhop.dir/all] Error 2
Makefile:90: recipe for target 'all' failed
make: *** [all] Error 2

Thank you very much for your time and assistance. Any guidance on how to resolve these compilation errors would be highly appreciated.

[hrvach]

Which gcc version are you using?

That section was patched recently indeed, but literally says:

    const int16_t jitter_distance = 2;
    static mouse_report_t report = {
        .y = jitter_distance,
        .mode = RELATIVE,
    };

so ... kinda is constant :) Builds fine on my end, but if it's a wider issue I'll change it to provide compatibility with older compilers.

[zoushiyin]

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.5.0-3ubuntu118.04' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu118.04)

[hrvach]

Thanks, I'll patch to use a #define and should be fine.