Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructable VRLayer instead of dictionary? #142

Closed
bfgeek opened this issue Nov 3, 2016 · 3 comments
Closed

Constructable VRLayer instead of dictionary? #142

bfgeek opened this issue Nov 3, 2016 · 3 comments
Milestone

Comments

@bfgeek
Copy link

bfgeek commented Nov 3, 2016

How likely is it that there will be different types of VRLayers in the future?

It might make more sense for VRLayer to be constructible directly? e.g.

const fovLayer = new VRFOVLayer({canvas: canvas});
fov.eyeSomethingSomething = something;

const rectLayer = new VRRectLayer({...});
rectLayer.position.m11 = something;

display.requestPresent([fovLayer, rectLayer]);

@domenic might have thoughts here.

Ian

@domenic
Copy link

domenic commented Nov 3, 2016

As far as I can tell it's already constructible.

@bfgeek
Copy link
Author

bfgeek commented Nov 3, 2016

Oh, I must have been looking at an old version of the spec in my browser, requestPresent seems broken then? @toji

@toji toji modified the milestone: 1.2 Dec 2, 2016
toji added a commit that referenced this issue Jan 7, 2017
Attempts to address #142, #107, #166, #156, and #125. Feedback welcome!
@toji
Copy link
Member

toji commented Feb 6, 2017

Going to close this as a duplicate of #107, and note that a solution has been proposed in #186

@toji toji closed this as completed Feb 6, 2017
@cwilso cwilso modified the milestones: Spec-Complete for 1.0, 1.0 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants