New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parquet format output not working in CLI #25960

Closed

Karribalu wants to merge 1 commit into influxdata:main from Karribalu:fix/parquet-format-output-not-working-cli

Karribalu commented Feb 4, 2025

Closes #25941

Describe your proposed changes here.
Replacing std::str::from_utf8 with String::from_utf8_lossy to handle Non-UTF-8 Characters

I've read the contributing section of the project README.
Signed CLA (if not already signed).


          fix: Parquet format output not working in CLI

4ba39d1

Contributor

hiltontj commented Feb 4, 2025

@Karribalu I am closing this for two reasons:

The problem in the related issue is not that the parquet data contains invalid UTF8, it is that there is not a way when using that format to save the resulting outputted bytes to a file.
Using _lossy conversion means the parquet data will be lost and invalid, which we do not want.

hiltontj closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet