Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI bug: Unit tests fail due to typo in git workflow #394

Open
courtneypacheco opened this issue Jan 16, 2025 · 0 comments · May be fixed by #395
Open

CI bug: Unit tests fail due to typo in git workflow #394

courtneypacheco opened this issue Jan 16, 2025 · 0 comments · May be fixed by #395
Assignees
@courtneypacheco
Labels
bug Something isn't working CI/CD Affects CI/CD configuration

Comments

@courtneypacheco
Copy link
Contributor

The unit tests in the CI immediately fail because a CI runner cannot be launched:

Image

This is because we have a typo in the unit testing workflow file that sets the instance type equal to the AWS region by mistake:

training/.github/workflows/unittesting-ci-nvidia.yaml

Line 51 in 0687995

ec2-instance-type: ${{ vars.AWS_REGION }}

@courtneypacheco courtneypacheco self-assigned this Jan 16, 2025
@courtneypacheco courtneypacheco linked a pull request Jan 16, 2025 that will close this issue
Open
@nathan-weinberg nathan-weinberg added bug Something isn't working CI/CD Affects CI/CD configuration labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@courtneypacheco courtneypacheco

Labels
bug Something isn't working CI/CD Affects CI/CD configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update ec2 instance type in unit test workflow file instructlab/training
2 participants
@courtneypacheco @nathan-weinberg