Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded references to api.thingspeak.com and thingspeak.com #44

Open
davidjb opened this issue Jun 14, 2016 · 0 comments
Open

Hardcoded references to api.thingspeak.com and thingspeak.com #44

davidjb opened this issue Jun 14, 2016 · 0 comments

Comments

@davidjb
Copy link

davidjb commented Jun 14, 2016

The current code base has a few locations where api.thingspeak.com or thingspeak.com are hard-coded for either loading data in JavaScript, charting or in the documentation. In some locations, either constants or template variables are already used in similar areas, so this would just be an extension of ensuring that they're used everywhere. Overall, this would make the code and documentation more flexible and portable for self-installs.

Would a PR be accepted that cleans these up and uses template variables and/or contstants based upon environment variables? The default can always match the current implementation (eg default to thingspeak.com etc).

From #37, the current version of thingspeak.com differs from what's currently on GitHub so it would be good to know whether there are updates coming from that version any time soon -- avoiding reimplementation would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant