Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode support for homepage #2909

Closed
gprasanth opened this issue Feb 7, 2021 · 2 comments · May be fixed by #2980
Closed

Add dark mode support for homepage #2909

gprasanth opened this issue Feb 7, 2021 · 2 comments · May be fixed by #2980
Labels
documentation enhancement starter good choice for new contributors

Comments

@gprasanth
Copy link

Tried adding dark mode support for the docs on the underscorejs.org homepage.

Here's how it looks before and after:

Screen Shot 2021-02-07 at 15 35 44
Screen Shot 2021-02-07 at 15 24 45

The code is available in a very short gist here:

doccy-dark.css

To submit a pull request I am not sure where to add this... in index.html in source root? or in docco.css?

In any case, this can be tweaked as required and added. Also, the logo lost the signature blue color, but can be avoided if an alternative logo image with white text is available.
@jgonggrijp
Copy link
Collaborator

Nice suggestion, thanks!

@jgonggrijp jgonggrijp added documentation enhancement starter good choice for new contributors labels Feb 7, 2021
@jgonggrijp jgonggrijp mentioned this issue Jul 12, 2021
Merged
@itsdeekay
Copy link

@gprasanth You can raise PR . Recommended would be to use in index.html itself as all of the existing code is inside it. Also it ca be separated in docs folder and with specified folder.

@j0pgrm j0pgrm mentioned this issue Sep 3, 2022
Closed
@jgonggrijp jgonggrijp mentioned this issue May 2, 2023
Open
@jgonggrijp jgonggrijp linked a pull request May 2, 2023 that will close this issue
Added dark mode button #2980
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement starter good choice for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added dark mode button yogi-25/underscore
3 participants
@gprasanth @jgonggrijp @itsdeekay