Replies: 1 comment
-
Ah, I like that idea, makes sense 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is sort of the reverse question to #2458 for
resolve
. Currently, the top-levelevaluate
function only accepts strings as the items to be evaluated, but in implementation, it always just parses any string operands to Nodes. So by analogy tosimplify
, shouldevaluate
be extended to also directly accept Nodes?In an only tangentially related implementation question,
evaluate
always invokescompile
on the Nodes, and then invokesevaluate
on the results of that. But Node itself has an evaluate method; wouldn't it be potentially a bit cleaner to call that directly (in case the implementation ofevaluate
on a Node is ever changed for some reason to something besides just to compile itself and call evaluate on the result?Beta Was this translation helpful? Give feedback.
All reactions