Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uniformize bigint construction #3375

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gwhitney
Copy link
Collaborator

Adds options to the bigint constructor function math.bigint() to
control whether/how non-integer inputs are rounded or errors thrown,
and whether "unsafe" values outside the range where integers can be
uniquely represented are converted. Changes math.numeric(x, 'bigint')
to call the bigint constructor configured to allow unsafe values but
throw on non-integers (closest approximation to its previous buggy
behavior).

Also restores documentation generation for constructor functions,
and initiates History sections in function doc pages.

Resolves #3366.
Resolves #3368.
Resolves #3341.

   Adds options to the bigint constructor function `math.bigint()` to
   control whether/how non-integer inputs are rounded or errors thrown,
   and whether "unsafe" values outside the range where integers can be
   uniquely represented are converted. Changes `math.numeric(x, 'bigint')`
   to call the bigint constructor configured to allow unsafe values but
   throw on non-integers (closest approximation to its previous buggy
   behavior).

   Also restores documentation generation for constructor functions,
   and initiates History sections in function doc pages.

   Resolves josdejong#3366.
   Resolves josdejong#3368.
   Resolves josdejong#3341.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant