Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the header contains ! (exclamation mark) then the type and subject are treated as empty #789

Open
almaceleste opened this issue Nov 17, 2024 · 4 comments

Comments

@almaceleste
Copy link

almaceleste commented Nov 17, 2024

If the header contains ! (exclamation mark) in type/scope part (to indicate breaking changes), then the type and subject are treated as empty.
This behavior occurs even if I disable subject-exclamation-mark rule:

        "subject-exclamation-mark": [0, "always"],

image

@joshbolduc
Copy link
Owner

Hmm, I can't seem to reproduce. Does the same thing happen if you use commitlint directly? If not, what version of commitlint do you have installed?

You could also try enabling commitlint.preferBundledLibraries and seeing if that changes anything.

@almaceleste
Copy link
Author

almaceleste commented Dec 1, 2024

commitlint CLI finds no errors in such COMMIT_MESSAGE file.
but commitliint extension does.
enabled commitlint.preferBundledLibraries option does not change this behavior.

commitlint CLI: 19.6.0
commitlint extension: 2.6.0
vscode: 1.95.3

upd: but if I put double exclamation marks (!!) to the header, commitlint CLI behaves the same as the extention.

@joshbolduc
Copy link
Owner

I still don't see this behavior myself, but there is a suspiciously similar sounding issue in the commitlint repo.

@almaceleste
Copy link
Author

yeah, looks similar, but I do not use semantic-release yet, and in my case it's the extension that complains, not the commitlint itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants