Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to r3f #3

Open
netgfx opened this issue Jun 20, 2023 · 2 comments
Open

Port to r3f #3

netgfx opened this issue Jun 20, 2023 · 2 comments

Comments

@netgfx
Copy link

netgfx commented Jun 20, 2023

Hello, I assume this project is not maintained anymore. But I thought I could ask, if you ever ported this to r3f or if you are interested in porting it.

I could pick up the task if you could give me some pointers about where to start. Thanks!

@juniorxsound
Copy link
Owner

Thanks @netgfx! and +1 - that'd be great!

If I was refactoring i'd probably start with

  • Porting over shader material (you could porbably use Drei's shaderMaterial wrapper
  • Writing a wrapper R3F component that exposes the params the plugin exposes as props

@netgfx
Copy link
Author

netgfx commented Jun 21, 2023

So far I managed to make it use the latest threejs, some changes on the examples around xr vs vr on the renderer and colorSpace on texture to silence some warnings. I'd say it works pretty well so far.
I guess next thing could be the wrapper first and the use of primitive from r3f instead of the threejs scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants