Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is not check for whether scaletargetref exists in webhook for scaleobject #6354

Closed
ctccxxd opened this issue Nov 21, 2024 · 2 comments
Closed

There is not check for whether scaletargetref exists in webhook for scaleobject #6354

ctccxxd opened this issue Nov 21, 2024 · 2 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@ctccxxd
Copy link
Contributor

ctccxxd commented Nov 21, 2024

Proposal

To check scaletargetref whether exists in scaleobject in webhook avoiding misconfiguration.

Use-Case

When users config a scaleobject, if the related scaletargetref is not found, currently webhook validate it.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

#6350 This is my code to solving this issue, welcome to review.
@ctccxxd ctccxxd added feature-request All issues for new features that have not been committed to needs-discussion labels Nov 21, 2024
@ctccxxd ctccxxd changed the title Ther is not check for whether scaletargetref exists in webhook for scaleobject There is not check for whether scaletargetref exists in webhook for scaleobject Nov 21, 2024
@ctccxxd ctccxxd mentioned this issue Nov 21, 2024
Open
5 tasks
@stale Stale
Copy link

stale bot commented Jan 21, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 21, 2025
@stale Stale
Copy link

stale bot commented Jan 28, 2025

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 28, 2025
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Roadmap - KEDA Core
Status: Ready To Ship
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctccxxd