Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error code for the world_divisions #26

Open
AnsonOHE opened this issue Mar 29, 2020 · 1 comment
Open

The error code for the world_divisions #26

AnsonOHE opened this issue Mar 29, 2020 · 1 comment

Comments

@AnsonOHE
Copy link

Hello, thanks for sharing the library. As check from the world_division, there is a small error between the code for these 2 rows of record, which is country_id = 87, name = "Pahang" and "Pulau Pinang", as found the code is not correct, it should be "ph" for "Pahang" and "pg" for "Pulau Pinang", kindly please update it. Thanks :)
As checked from the web, it is recommended to put the code to "png" for the "Pulau Pinang" rather than only "pg", same for others with the country_id = 87.

@khsing
Copy link
Owner

khsing commented Mar 7, 2021

@AnsonOHE according to this wiki: https://en.wikipedia.org/wiki/ISO_3166-2:MY, I think it better way to update code with numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants