Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones? #29

Open
wrabit opened this issue Jun 21, 2020 · 2 comments
Open

Timezones? #29

wrabit opened this issue Jun 21, 2020 · 2 comments
Labels
enhancement feature new feature for this package

Comments

@wrabit
Copy link

wrabit commented Jun 21, 2020

How can we add timezone to each city?

@khsing
Copy link
Owner

khsing commented Jul 10, 2020

sure, but we need data source to do this.

@khsing khsing added enhancement feature new feature for this package labels Mar 6, 2021
@seche
Copy link

seche commented Jul 21, 2021

https://download.geonames.org/export/dump/ seems like a good source. Has a few dumps for cities by population. And they all link to an IANA Timezone which is what PHP uses.

@khsing did you prefer to add a timezone field in cities or a new timezone table with abbreviation and time offsets? PHP comes with DateTimeZone::Class that handles the information as needed and I think the table might be redundant. Could easily have the functionality with a timezone trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature new feature for this package
Projects
None yet
Development

No branches or pull requests

3 participants