Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding other proxy middlewares #93

Open
percyhanna opened this issue Sep 6, 2018 · 0 comments
Open

Adding other proxy middlewares #93

percyhanna opened this issue Sep 6, 2018 · 0 comments

Comments

@percyhanna
Copy link

percyhanna commented Sep 6, 2018

See tshaddix/webext-redux#163 for a bit of context (from react-chrome-redux).

The main limitation with react-chrome-redux is the requirement to separate local actions from background/aliased actions.

electron-redux seems like it would be easier to morph to fit my needs (and, I also need an Electron proxy store, so that's another benefit). electron-redux seems to be nicely architected to allow for the introduction of other middleware(s) to handle other environments like Chrome. The concept of a proxied store is obviously one that many people feel is useful, and I wonder if a more generic module could be created that includes middleware providers for Chrome, Electron, and potentially other environments as well.

I'm likely going to mimic electron-redux's code to create a Chrome store proxy à-la react-chrome-redux, but with the ability to separate local and aliased actions.

For now I could just create a separate module that mimics electron-redux's API, and it would provide forwardToRenderer and forwardToMain alternatives. I'm hoping that only replacing those two functions would be the only changes needed to support a proxy store in Chrome extensions.

So I suppose the question would be if there's the possibility of eventually moving to a more generic module (e.g. redux-proxy-store) that could support any number of middleware(s).

Thanks for the great work on electron-redux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant