Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit Collection & NFT UI #11171

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 30, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

not closing some issues since some UI/UX changes may be needed

Screenshot 📸

  • My fix has changed something on UI;

Edit NFT

CleanShot 2024-11-05 at 11 45 44@2x

Edit Collection

CleanShot 2024-10-30 at 18 42 03@2x

Refresh Collection Nfts Metadata

CleanShot 2024-10-30 at 18 42 27@2x

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3084239
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6729cd62b7a0790009df97ae
😎 Deploy Preview https://deploy-preview-11171--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


const args = [
api.tx.nfts.setCollectionMetadata(collectionId, metadata),
api.tx.nfts.setCollectionMaxSupply(collectionId, item.collection.max),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if supply does not change, I would skip the call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vikiival
Copy link
Member

Amazing ❤️❤️
I am just thinking how to add

also I would make the modal wider WDYT @exezbcz

@hassnian hassnian changed the title feat: Collection edit UI feat: Edit Collection & NFT UI Nov 4, 2024
@hassnian hassnian marked this pull request as ready for review November 5, 2024 07:16
@hassnian hassnian requested a review from a team as a code owner November 5, 2024 07:16
@hassnian hassnian requested review from preschian and vikiival and removed request for a team November 5, 2024 07:16
Copy link

sonarcloud bot commented Nov 5, 2024

@exezbcz
Copy link
Member

exezbcz commented Nov 5, 2024

also I would make the modal wider WDYT @exezbcz

I would keep the width the same for the consistency

After adding more features, if we conclude it needs to be wider, we can change that.

Anyway, good job @hassnian !

@exezbcz
Copy link
Member

exezbcz commented Nov 5, 2024

will editing an nft create on chain event that will be in the activity tab?

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great pr 🚀

const metadata = (await processSingleMetadata(
collectionMetadata,
)) as TokenMetadata
const metadata = await processSingleMetadata<TokenMetadata>(collectionMetadata)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update types? or using another types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type did not change just using generic types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata.banner does not exists in this type, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yes this type doesn't have banner, should we update the hyperdata type or create a local one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather make PR to kodadot/packages

@hassnian
Copy link
Contributor Author

will editing an nft create on chain event that will be in the activity tab?

atm no, the indexer does not have an UPDATE_METADATA event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants