-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit Collection & NFT UI #11171
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
const args = [ | ||
api.tx.nfts.setCollectionMetadata(collectionId, metadata), | ||
api.tx.nfts.setCollectionMaxSupply(collectionId, item.collection.max), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if supply does not change, I would skip the call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Amazing ❤️❤️ also I would make the modal wider WDYT @exezbcz |
- added <LogoField /> component to reuse logo field section
…es with "UpdateCollectionStatemine".
Quality Gate passedIssues Measures |
will editing an nft create on chain event that will be in the activity tab? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great pr 🚀
const metadata = (await processSingleMetadata( | ||
collectionMetadata, | ||
)) as TokenMetadata | ||
const metadata = await processSingleMetadata<TokenMetadata>(collectionMetadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update types? or using another types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the type did not change just using generic types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadata.banner
does not exists in this type, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yes this type doesn't have banner, should we update the hyperdata
type or create a local one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather make PR to kodadot/packages
PR Type
Context
not closing some issues since some UI/UX changes may be needed
Screenshot 📸
Edit NFT
Edit Collection
Refresh Collection Nfts Metadata