Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for sec=krb5 mounting #606

Merged
merged 1 commit into from
May 6, 2023
Merged

feat: add support for sec=krb5 mounting #606

merged 1 commit into from
May 6, 2023

Conversation

yerenkow
Copy link
Contributor

@yerenkow yerenkow commented May 2, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Adding support for more secure mounting, without exposing password

Which issue(s) this PR fixes:
Fixes #512

Requirements:

Special notes for your reviewer:

Release note:

Adding support for passwordless mounting on linux using provided kerberos credential cache with tickets.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 2, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yerenkow!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yerenkow. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2023
@andyzhangx
Copy link
Member

@yerenkow thanks for the contribution, could you sign the cla first?

@coveralls
Copy link

coveralls commented May 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4873898931

  • 43 of 74 (58.11%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 82.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 43 74 58.11%
Totals Coverage Status
Change from base Build 4842039541: -1.8%
Covered Lines: 885
Relevant Lines: 1073
💛 - Coveralls

andyzhangx
andyzhangx reviewed May 3, 2023
View reviewed changes
pkg/smb/nodeserver.go Outdated Show resolved Hide resolved
pkg/smb/nodeserver.go Outdated Show resolved Hide resolved
docs/driver-parameters.md Outdated Show resolved Hide resolved
pkg/smb/nodeserver.go Outdated Show resolved Hide resolved
@yerenkow yerenkow force-pushed the support-kerberos-ticket branch 2 times, most recently from 56f6742 to 57cf140 Compare May 3, 2023 15:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 3, 2023
@yerenkow
Copy link
Contributor Author

yerenkow commented May 4, 2023

@andyzhangx Thanks for review - I've updated and signed cla.

andyzhangx
andyzhangx reviewed May 5, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@andyzhangx andyzhangx changed the title Adding support for sec=krb5 mounting feat: add support for sec=krb5 mounting May 5, 2023
andyzhangx
andyzhangx reviewed May 5, 2023
View reviewed changes
pkg/smb/nodeserver.go Outdated Show resolved Hide resolved
docs/driver-parameters.md Outdated Show resolved Hide resolved
@yerenkow
Adding support for sec=krb5 mounting
d9aa489 
When mounting with kerberos security, ticket cache
is expected to be set up on the host, pointing to the
/var/lib/kubelet/kubernetes/krb5cc_${uid}.
Credential cache is then taken from the creds secret and
written to the file, that is available to the host for
using.
@yerenkow yerenkow force-pushed the support-kerberos-ticket branch from 57cf140 to d9aa489 Compare May 5, 2023 17:39
andyzhangx
andyzhangx approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, yerenkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 81e2973 into kubernetes-csi:master May 6, 2023
@andyzhangx
Copy link
Member

andyzhangx commented Jan 10, 2024 •
edited
Loading

@yerenkow when the kerberos ticket is expired, how does this driver handle this issue? do we need to unmount the pv and mount again?

@mhvelplund mhvelplund mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kerberos ticket
4 participants
@yerenkow @k8s-ci-robot @andyzhangx @coveralls