Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore NodeDrainSpec test from CAPI #5392

Open
mboersma opened this issue Jan 27, 2025 · 1 comment
Open

Restore NodeDrainSpec test from CAPI #5392

mboersma opened this issue Jan 27, 2025 · 1 comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@mboersma
Copy link
Contributor

mboersma commented Jan 27, 2025 •
edited
Loading

In #5316 we commented out the NodeDrainSpec after convincing ourselves that this test we borrow from CAPI had changed in ways that are too specific to the Docker provider implementation. Let's investigate making the CAPI test more flexible, and seeing if we can re-enable the test once that's done.

Anything else we need to know:

/kind failing-test
@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 27, 2025
@mboersma mboersma mentioned this issue Jan 27, 2025
Merged
4 tasks
@willie-yao
Copy link
Contributor

Relevant discussion in the CAPI Slack: https://kubernetes.slack.com/archives/C8TSNPY4T/p1737758452258119. There may be issues with how we set up Calico as some CAPI maintainers mentioned the pod should terminate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
CAPZ Planning
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mboersma @k8s-ci-robot @willie-yao