Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for model servers other than vllm #95

Open
ahg-g opened this issue Dec 12, 2024 · 1 comment
Open

Support for model servers other than vllm #95

ahg-g opened this issue Dec 12, 2024 · 1 comment

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Dec 12, 2024

Currently the implementation is hardcoded for vllm support, we need to have a way to make it configurable to support other model servers; for example pass in the names of the metrics that the algorithm depends on rather than hardcoding them.

@liu-cong
Copy link
Contributor

liu-cong commented Jan 8, 2025

Currently it's not quite feasible to have a generic solution for any model server, until we finalize the model server protocol and implement it, which will take time. Plus, implementing more model servers help us discover new requirements that should go to the protocol.

Luckily, our interaction surface with model servers is really small (mostly scraping metrics). So I propose the short term solution.

  • Add a modelServer flag to the ext-proc binary to tell which model server to use.
  • Add a enableLoRA flag to the ext-proc binary. If LoRA is enabled, then we will scrape LoRA metrics.
  • Add an internal map dada structure to define the model server to metric name mapping, and extract out the helper functions in existing vllm implementation.
  • If there is any bespoke logic we need for a new model server, consider adding a new implementation in the backend package. But we need to be mindful and keep this minimal.

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants