fix: improved site accessibility #6181
Open
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aakankshabhende <[email protected]>
|
🚀 Preview for commit 74e782a at: https://677e83d0b4b0135dfe7e4f54--layer5.netlify.app |
|
@aakankshabhende adding it as an agenda item to the meeting minutes. |
|
@vishalvivekm Could you please review this? |
leecalcote
reviewed
Jan 16, 2025
| @@ -34,6 +34,7 @@ const SocialLinksColor = () => { | |||
| target="_blank" | |||
| rel="noreferrer" | |||
| className="footer_twitter" | |||
| aria-label="Visit Layer5 on Twitter" | |||
| @@ -95,7 +95,7 @@ const Features = (props) => { | |||
| : (<div className="small-card-container"> | |||
| {props.redirectLinkWithImage.map((item) => ( | |||
| <Link key={item.text} className="small-card" to={item.redirect}> | |||
| <img src={item.image} width={40} /> | |||
| <img src={item.image} width={40} alt={`${item.text} icon`}/> | |||
| @@ -288,7 +288,8 @@ const IntegrationsGrid = ({ category, count }) => { | |||
| ? darkModeIntegrationIcon.publicURL | |||
| : integrationIcon | |||
| } | |||
| alt={item.frontmatter.title} | |||
| alt={`${item.frontmatter.title} image`} | |||
| aria-label={`${item.frontmatter.title} image`} | |||
| {menu.subItems !== undefined && ( | ||
| <ul> | ||
| {menu.subItems.map((subItem, subIndex) => ( | ||
| <li key={subIndex} className="mobile-nav-subitem"> |
There was a problem hiding this comment.
We no longer need the return() function here?
There was a problem hiding this comment.
No it is not needed here because it will implicitly return the values.Am I right @aakankshabhende?
|
I love seeing this. Thank you, @aakankshabhende! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The site accessibility score has been improved from 74 to 91. The changes which can further improve the score aren't possible because that involves colour change that doesn't match our brand and other significant UI changes such as increasing font size.
This PR fixes #6148
Notes for Reviewers
Signed commits