fixes leahneukirchen/mblaze#194 #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this will work, as we had the explicit cases exactly for 6 lines by default, you'd need to generalize the algorithm. Also note that in POSIX sh you can use |
ah. ok. i see. you mean we have to do a loop around https://github.com/leahneukirchen/mblaze/pull/223/files#diff-0f549fd15ac39a405676bb080ab4f082f510f787923824ac807f07b45b86a8e3R30 ? this make the thing a bit more complicated. i will take a closer look later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #194
Why
Configure the number of lines which are shown on top of
mlesswould be nice to have.How
Introduce property
Scan-Linesavailable in$MBLAZE/profileto configure the number of lines to scan on top ofmless.mlessreads this property and using it. if not set the default value of6is used to not break the existing behaviour.Also updating the man pages for mless and
mblaze-profile.